Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cmd typo #15405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: cmd typo #15405

wants to merge 2 commits into from
+1 −1

Conversation

strikoza
Copy link

for easier copy/pasting the command

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@strikoza
cmd typo
98207ac 
for easier copy/pasting the command
@strikoza strikoza requested a review from a team as a code owner December 13, 2024 10:25
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JStickler
❌ strikoza
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 13, 2024
JStickler
JStickler approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for taking the time to update the docs!

@JStickler
Copy link
Contributor

@strikoza You need to sign the CLA before I can merge this PR.

@JStickler JStickler changed the title cmd typo docs: cmd typo Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strikoza @CLAassistant @JStickler @cyriltovena